[2-10-test] Bump hatch version in breeze and prevent "get-workflow-info" failure … #45064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#45041) We enabled dependabot to bump dependencies for various Python requirements we have in Airflow and it found out that we have pretty out-dated hatch - pinned because of metadata stability when building packages. The update caused "get-workflow-info" step in CI to fail because the "get-workflow-info" commmand contained output from uv upgrading breeze while it was running. This PR bumps the version manually to the latest version, also it sets `SKIP_BREEZE_SELF_UPGRADE_CHECK` variable to true in the `get-workflow-info` step - to prevent breeze from checking and automatically upgrading itself. This will not make future dependabot PRs to succeed, because those PRs will not update hash of README file - so the PRs will fail at the pre-commit stage, but at least it will be clear what should be done to fix it. Also a bit of cleanup has been done opportunistically: * the TODO on flit automation can now be removed as we have dependabot taking care about it automatically in both places that we were supposed to automate * the importlib_resources exclusions were only used for Python < 3.9 and we are now >= 3.0 so we can remove it
jscheffl
approved these changes
Dec 18, 2024
Lee-W
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#45041)
We enabled dependabot to bump dependencies for various Python requirements we have in Airflow and it found out that we have pretty out-dated hatch - pinned because of metadata stability when building packages. The update caused "get-workflow-info" step in CI to fail because the "get-workflow-info" commmand contained output from uv upgrading breeze while it was running.
This PR bumps the version manually to the latest version, also it sets
SKIP_BREEZE_SELF_UPGRADE_CHECKvariable to true in theget-workflow-infostep - to prevent breeze from checking and automatically upgrading itself.This will not make future dependabot PRs to succeed, because those PRs will not update hash of README file - so the PRs will fail at the pre-commit stage, but at least it will be clear what should be done to fix it.
Also a bit of cleanup has been done opportunistically:
the TODO on flit automation can now be removed as we have dependabot taking care about it automatically in both places that we were supposed to automate
the importlib_resources exclusions were only used for Python < 3.9 and we are now >= 3.0 so we can remove it
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.