Add MessageDeduplicationId support to AWS SqsPublishOperator #45051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
approved these changes
Dec 18, 2024
eladkal
requested changes
Dec 19, 2024
Contributor
eladkal
left a comment
eladkal
left a comment
There was a problem hiding this comment.
Needs also a test for the success scenario.
You can add the needed changes to test_execute_success or write a separated test if needed
Contributor
Author
Done! |
Contributor
|
@eladkal ? |
eladkal
approved these changes
Jan 7, 2025
eladkal
force-pushed
the
add-MessageDeduplicationId-support-to-SqsPublishOperator
branch
from
3b5918b to
860b6ea
Compare
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
…45051) * add MessageDeduplicationId support to AWS SqsPublishOperator * modified test --------- Co-authored-by: pratiksha rajendrabhai badheka <pratiksha@DESKTOP-T5HUA05>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…45051) * add MessageDeduplicationId support to AWS SqsPublishOperator * modified test --------- Co-authored-by: pratiksha rajendrabhai badheka <pratiksha@DESKTOP-T5HUA05>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes : #44876
Currently, the
SqsPublishOperatorin Airflow does not support theMessageDeduplicationIdparameter for deduplication of messages sent to AWS SQS FIFO queues. Users are forced to rely solely onContentBasedDeduplication, which may not be suitable for all scenarios.This PR aims to add support for
MessageDeduplicationIdand test for deduplication to provide more flexibility and control over message deduplication.(https://boto3.amazonaws.com/v1/documentation/api/1.35.6/reference/services/sqs/client/send_message.html))
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.