-
Notifications
You must be signed in to change notification settings - Fork 16.4k
AIP-72: Allow retrieving Connection from Task Context #45043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| from __future__ import annotations | ||
|
|
||
| import attrs | ||
|
|
||
|
|
||
| @attrs.define | ||
| class Connection: | ||
| """ | ||
| A connection to an external data source. | ||
|
|
||
| :param conn_id: The connection ID. | ||
| :param conn_type: The connection type. | ||
| :param description: The connection description. | ||
| :param host: The host. | ||
| :param login: The login. | ||
| :param password: The password. | ||
| :param schema: The schema. | ||
| :param port: The port number. | ||
| :param extra: Extra metadata. Non-standard data such as private/SSH keys can be saved here. JSON | ||
| encoded object. | ||
| """ | ||
|
|
||
| conn_id: str | ||
| conn_type: str | ||
| description: str | None = None | ||
| host: str | None = None | ||
| schema: str | None = None | ||
| login: str | None = None | ||
| password: str | None = None | ||
| port: int | None = None | ||
| extra: str | None = None | ||
|
|
||
| def get_uri(self): ... | ||
|
|
||
| def get_hook(self): ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING, Any | ||
|
|
||
| import structlog | ||
|
|
||
| from airflow.sdk.exceptions import AirflowRuntimeError, ErrorType | ||
|
|
||
| if TYPE_CHECKING: | ||
| from airflow.sdk.definitions.connection import Connection | ||
| from airflow.sdk.execution_time.comms import ConnectionResult | ||
|
|
||
|
|
||
| def _convert_connection_result_conn(conn_result: ConnectionResult): | ||
| from airflow.sdk.definitions.connection import Connection | ||
|
|
||
| # `by_alias=True` is used to convert the `schema` field to `schema_` in the Connection model | ||
| return Connection(**conn_result.model_dump(exclude={"type"}, by_alias=True)) | ||
ashb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
| def _get_connection(conn_id: str) -> Connection: | ||
| # TODO: This should probably be moved to a separate module like `airflow.sdk.execution_time.comms` | ||
| # or `airflow.sdk.execution_time.connection` | ||
kaxil marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # A reason to not move it to `airflow.sdk.execution_time.comms` is that it | ||
| # will make that module depend on Task SDK, which is not ideal because we intend to | ||
| # keep Task SDK as a separate package than execution time mods. | ||
| from airflow.sdk.execution_time.comms import ErrorResponse, GetConnection | ||
| from airflow.sdk.execution_time.task_runner import SUPERVISOR_COMMS | ||
|
|
||
| log = structlog.get_logger(logger_name="task") | ||
| SUPERVISOR_COMMS.send_request(log=log, msg=GetConnection(conn_id=conn_id)) | ||
| msg = SUPERVISOR_COMMS.get_message() | ||
| if isinstance(msg, ErrorResponse): | ||
| raise AirflowRuntimeError(msg) | ||
|
|
||
| if TYPE_CHECKING: | ||
| assert isinstance(msg, ConnectionResult) | ||
| return _convert_connection_result_conn(msg) | ||
|
|
||
|
|
||
| class ConnectionAccessor: | ||
| """Wrapper to access Connection entries in template.""" | ||
|
|
||
| def __getattr__(self, conn_id: str) -> Any: | ||
| return _get_connection(conn_id) | ||
|
|
||
| def __repr__(self) -> str: | ||
| return "<ConnectionAccessor (dynamic access)>" | ||
kaxil marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| def __eq__(self, other): | ||
| if not isinstance(other, ConnectionAccessor): | ||
| return False | ||
| # All instances of ConnectionAccessor are equal since it is a stateless dynamic accessor | ||
| return True | ||
|
|
||
| def get(self, conn_id: str, default_conn: Any = None) -> Any: | ||
| try: | ||
| return _get_connection(conn_id) | ||
| except AirflowRuntimeError as e: | ||
| if e.error.error == ErrorType.CONNECTION_NOT_FOUND: | ||
| return default_conn | ||
| raise | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.