-
Notifications
You must be signed in to change notification settings - Fork 16.4k
AIP-72: Handling "up_for_reschedule" task instance states #44907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
ashb
reviewed
Dec 16, 2024
ashb
reviewed
Dec 16, 2024
kaxil
reviewed
Dec 16, 2024
kaxil
reviewed
Dec 16, 2024
kaxil
reviewed
Dec 17, 2024
kaxil
reviewed
Dec 18, 2024
kaxil
reviewed
Dec 18, 2024
kaxil
reviewed
Dec 18, 2024
kaxil
reviewed
Dec 18, 2024
kaxil
reviewed
Dec 18, 2024
kaxil
approved these changes
Dec 18, 2024
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving (lgtm high-level), but please address the comments
Contributor
Author
|
@kaxil merging this one. I think I have handled the comments on this |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #44414
Server side changes (execution api):
TIRescheduleStatePayloadinti_update_state-> covered by unit test:test_ti_update_state_to_rescheduleClient side changes (task sdk):
HTTP client:
Added a new function defer that sends a patch request to the
task-instances/{id}/state executionapi with payload:RescheduleTaskComms:
Defining a new data model to send a request to patch ti as "up_for_reschedule" from task runner to supervisor:
RescheduleTask(Added to ToSupervisor)Supervisor:
handle_requeststo receive requests from task runner and forwarding the message to http client to call reschedule.TaskRunner:
Task runner executes: ti.task.execute and raises
AirflowRescheduleExceptionfor rescheduling. This sends a request to supervisor usingSUPERVISOR_COMMSExample DAG with which this was tested:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.