-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Set Autocomplete Off on Login Form #44780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…f for username and password input elements on AUTH_DB login page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, tested locally, working as expected.
Should we target main and backport instead of specifically targeting v2-10-test. When changes are compatible I believe main then backport is better to limit drift between the two branches, I tend to directly target v2-10-test for changes that are completely different and incompatible with main anymore. @ephraimbuddy what do you think ?
I agree with you. Main then backport, for changes that are a bit compatible otherwise a different PR targeting the test branch would be better |
|
Closing this PR, since we decided to push this one to New PR: #44929 |
Closes #44019
Updated main Javascript to apply
autocomplete="off"to both username and password inputs on login page. This will help prevent the browser from providing hints for the username (and password), as requested in the Issue.Based on Flask-AppBuilder source code, i.e. https://github.com/dpgaspar/Flask-AppBuilder/tree/master/flask_appbuilder/templates/appbuilder/general/security (see
login_db.htmlandlogin_ldap.html), this should work for bothAUTH_DB(default) andAUTH_LDAPauthentication, since they both apparently use the same HTML elements in the form.