Skip to content

Conversation

@geraj1010
Copy link
Contributor

@geraj1010 geraj1010 commented Dec 9, 2024

Closes #44019

Updated main Javascript to apply autocomplete="off" to both username and password inputs on login page. This will help prevent the browser from providing hints for the username (and password), as requested in the Issue.

Based on Flask-AppBuilder source code, i.e. https://github.com/dpgaspar/Flask-AppBuilder/tree/master/flask_appbuilder/templates/appbuilder/general/security (see login_db.html and login_ldap.html), this should work for both AUTH_DB (default) and AUTH_LDAP authentication, since they both apparently use the same HTML elements in the form.

…f for username and password input elements on AUTH_DB login page
@geraj1010 geraj1010 changed the base branch from main to v2-10-test December 9, 2024 18:14
@uranusjr uranusjr added area:UI Related to UI/UX. For Frontend Developers. legacy ui Whether legacy UI change should be allowed in PR and removed area:dev-tools area:API Airflow's REST/HTTP API area:production-image Production image improvements and fixes labels Dec 9, 2024
@uranusjr uranusjr removed the request for review from ephraimbuddy December 9, 2024 19:52
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested locally, working as expected.

Should we target main and backport instead of specifically targeting v2-10-test. When changes are compatible I believe main then backport is better to limit drift between the two branches, I tend to directly target v2-10-test for changes that are completely different and incompatible with main anymore. @ephraimbuddy what do you think ?

@ephraimbuddy
Copy link
Contributor

Nice, tested locally, working as expected.

Should we target main and backport instead of specifically targeting v2-10-test. When changes are compatible I believe main then backport is better to limit drift between the two branches, I tend to directly target v2-10-test for changes that are completely different and incompatible with main anymore. @ephraimbuddy what do you think ?

I agree with you. Main then backport, for changes that are a bit compatible otherwise a different PR targeting the test branch would be better

@geraj1010
Copy link
Contributor Author

Closing this PR, since we decided to push this one to main and backtrack to v2-10-test.

New PR: #44929

@geraj1010 geraj1010 closed this Dec 14, 2024
@geraj1010 geraj1010 deleted the airflow_44019 branch December 14, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. legacy ui Whether legacy UI change should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocomplete Attribute Not Disabled for Password Fields in Login Forms

5 participants