Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent using trigger_rule=TriggerRule.ALWAYS in a task-generated mapping within bare tasks #44751

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Dec 6, 2024

related: #43368

Thanks to Jed's comment in the previous PR, I've realized that:

  1. I've made a mistake in terminology, and mixed up dynamic task mapping with task-generated mapping.
  2. The previous PR covered only the case of mapped task groups, but didn't cover the case of bare tasks (see example in the comment / test).

This PR fixes related docs and newsfragment of #43368, while applying the prevention for bare tasks.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 requested a review from jedcunningham December 6, 2024 22:06
@shahar1 shahar1 requested a review from potiuk as a code owner December 6, 2024 22:06
@shahar1 shahar1 added this to the Airflow 2.10.4 milestone Dec 6, 2024
@shahar1 shahar1 added area:core kind:task A task that needs to be completed as part of a larger issue area:dynamic-task-mapping AIP-42 type:improvement Changelog: Improvements kind:documentation and removed kind:documentation kind:task A task that needs to be completed as part of a larger issue labels Dec 6, 2024
@shahar1 shahar1 requested review from uranusjr and eladkal December 6, 2024 22:31
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! Thanks @shahar1!

newsfragments/43368.improvement.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahar1 shahar1 merged commit 5d77bda into apache:main Dec 7, 2024
50 checks passed
@shahar1 shahar1 deleted the fix-43368 branch December 7, 2024 16:35
@shahar1 shahar1 added the backport-to-v2-10-test Mark PR with this label to backport to v2-10-test branch label Dec 7, 2024
@shahar1
Copy link
Contributor Author

shahar1 commented Dec 7, 2024

Working on a backport :)

shahar1 added a commit to shahar1/airflow that referenced this pull request Dec 7, 2024
shahar1 added a commit that referenced this pull request Dec 8, 2024
utkarsharma2 pushed a commit that referenced this pull request Dec 10, 2024
…generated mapping within bare tasks (#44751) (#44769)

(cherry picked from commit 99e713e)
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core area:dynamic-task-mapping AIP-42 area:task-sdk backport-to-v2-10-test Mark PR with this label to backport to v2-10-test branch kind:documentation type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants