-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent using trigger_rule=TriggerRule.ALWAYS
in a task-generated mapping within bare tasks
#44751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahar1
added
area:core
kind:task
A task that needs to be completed as part of a larger issue
area:dynamic-task-mapping
AIP-42
type:improvement
Changelog: Improvements
kind:documentation
and removed
kind:documentation
kind:task
A task that needs to be completed as part of a larger issue
labels
Dec 6, 2024
eladkal
reviewed
Dec 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good! Thanks @shahar1!
shahar1
added
type:bug-fix
Changelog: Bug Fixes
kind:documentation
and removed
kind:documentation
type:improvement
Changelog: Improvements
labels
Dec 7, 2024
eladkal
approved these changes
Dec 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…apping within bare tasks
jedcunningham
approved these changes
Dec 7, 2024
shahar1
added
the
backport-to-v2-10-test
Mark PR with this label to backport to v2-10-test branch
label
Dec 7, 2024
Working on a backport :) |
shahar1
added a commit
to shahar1/airflow
that referenced
this pull request
Dec 7, 2024
…generated mapping within bare tasks (apache#44751)
33 tasks
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
…apping within bare tasks (apache#44751)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:core
area:dynamic-task-mapping
AIP-42
area:task-sdk
backport-to-v2-10-test
Mark PR with this label to backport to v2-10-test branch
kind:documentation
type:bug-fix
Changelog: Bug Fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #43368
Thanks to Jed's comment in the previous PR, I've realized that:
This PR fixes related docs and newsfragment of #43368, while applying the prevention for bare tasks.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.