Skip to content

Removed deprecated code from Alibaba provider package #44576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Dec 16, 2024
Merged

Removed deprecated code from Alibaba provider package #44576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7233493
issue 44559
Tushar4432 Dec 2, 2024
3f69dde
Apply suggestions from code review
eladkal Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions providers/src/airflow/providers/alibaba/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,20 @@
Changelog
---------



.. warning::
All deprecated classes, parameters and features have been removed from the alibaba provider package.
The following breaking changes were introduced:

* Operators
* Remove ``get_hook`` method from ``AnalyticDBSparkBaseOperator``. Use ``self.hook`` instead.

* sensors
* Remove ``get_hook`` method from ``AnalyticDBSparkSensor``. Use ``self.hook`` instead.



2.9.1
.....

Expand Down
9 changes: 1 addition & 8 deletions providers/src/airflow/providers/alibaba/cloud/operators/analyticdb_spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@
from functools import cached_property
from typing import TYPE_CHECKING, Any

from deprecated.classic import deprecated

from airflow.exceptions import AirflowException, AirflowProviderDeprecationWarning
from airflow.exceptions import AirflowException
from airflow.models import BaseOperator
from airflow.providers.alibaba.cloud.hooks.analyticdb_spark import AnalyticDBSparkHook, AppState

Expand Down Expand Up @@ -56,11 +54,6 @@ def hook(self) -> AnalyticDBSparkHook:
"""Get valid hook."""
return AnalyticDBSparkHook(adb_spark_conn_id=self._adb_spark_conn_id, region=self._region)

@deprecated(reason="use `hook` property instead.", category=AirflowProviderDeprecationWarning)
def get_hook(self) -> AnalyticDBSparkHook:
"""Get valid hook."""
return self.hook

def execute(self, context: Context) -> Any: ...

def monitor_application(self):
Expand Down
8 changes: 0 additions & 8 deletions providers/src/airflow/providers/alibaba/cloud/sensors/analyticdb_spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
from functools import cached_property
from typing import TYPE_CHECKING, Any

from deprecated.classic import deprecated

from airflow.exceptions import AirflowProviderDeprecationWarning
from airflow.providers.alibaba.cloud.hooks.analyticdb_spark import AnalyticDBSparkHook, AppState
from airflow.sensors.base import BaseSensorOperator

Expand Down Expand Up @@ -60,11 +57,6 @@ def hook(self) -> AnalyticDBSparkHook:
"""Get valid hook."""
return AnalyticDBSparkHook(adb_spark_conn_id=self._adb_spark_conn_id, region=self._region)

@deprecated(reason="use `hook` property instead.", category=AirflowProviderDeprecationWarning)
def get_hook(self) -> AnalyticDBSparkHook:
"""Get valid hook."""
return self.hook

def poke(self, context: Context) -> bool:
app_id = self.app_id

Expand Down