Add tests cases for multiple executors in chart #44424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
eladkal
force-pushed
the
add-tests-with-new-executors
branch
from
819a12e to
55cfc01
Compare
amoghrajesh
approved these changes
Jan 6, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
LGTM +1 thanks.
One qn
romsharon98
force-pushed
the
add-tests-with-new-executors
branch
from
55cfc01 to
beec000
Compare
eladkal
approved these changes
Jan 6, 2025
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
* add examples for tests with multiple executors * fix pod-launcher-rolebinding to handel multiple executors * fix hpa tests * remove deprecated test
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* add examples for tests with multiple executors * fix pod-launcher-rolebinding to handel multiple executors * fix hpa tests * remove deprecated test
62 tasks
Atharv625
reviewed
Apr 15, 2025
Atharv625
left a comment
Atharv625
left a comment
There was a problem hiding this comment.
Good catch on the Helm template bug — this unblocks Helm upgrades for many users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #43606
adding examples to all files changed in the related PR to check validity for multiple executors and fix the errors.
with the tests, I found a problem in
chart/templates/rbac/pod-launcher-rolebinding.yamlso I fix it here too.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.