AIP84: Check standalone_dag_processor config in get_airflow_health() and update health endpoint #44383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:API
rawwar
reviewed
Nov 26, 2024
vatsrahul1001
force-pushed
the
AIP84-health-endpoint-skip-dag-processor
branch
from
68b8f22 to
54ac2c3
Compare
vatsrahul1001
force-pushed
the
AIP84-health-endpoint-skip-dag-processor
branch
from
54ac2c3 to
4932f69
Compare
…:astronomer/airflow into AIP84-health-endpoint-skip-dag-processor
vatsrahul1001
changed the title
…:astronomer/airflow into AIP84-health-endpoint-skip-dag-processor
…:astronomer/airflow into AIP84-health-endpoint-skip-dag-processor
rawwar
reviewed
Nov 27, 2024
rawwar
reviewed
Nov 27, 2024
…:astronomer/airflow into AIP84-health-endpoint-skip-dag-processor
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
…and update health endpoint (apache#44383) * AIP84 health endpoint skip dag processor * AIP84 health endpoint skip dag processor * fixing test_airflow_health tests and adding new tests * AIP84 health endpoint skip dag processor * AIP84 health endpoint skip dag processor * fixing test_airflow_health tests and adding new tests * fix static tests * Using only one model class HealthInfoSchema * fixing static checks * implement review comments * fix static tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #44253
Motivation
Right now the UI has to check the scheduler config for standalone_dag_processor in order to determine if the dag_processor health check should be rendered.
This PR does that check-in get_airflow_health() and also handles this inthe
public/healthendpoint.Testing
Response with DAG Processor enabled
Response with DAG Processor disabled
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.