Bugfix KubernetesJobOperator.on_kill() #44131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiseenkov
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Contributor
|
Can you amend the commit to a meaningful one? We use commit titles for change log |
moiseenkov
force-pushed
the
k8s_delete_namespaced_job
branch
from
e750cd4 to
e3f23e2
Compare
Contributor
Author
Done. Thanks for noticing! |
moiseenkov
force-pushed
the
k8s_delete_namespaced_job
branch
from
e3f23e2 to
6bc3e16
Compare
…rgument from the k8s job client method `delete_namespaced_job` invocation
moiseenkov
force-pushed
the
k8s_delete_namespaced_job
branch
from
6bc3e16 to
edb0230
Compare
potiuk
approved these changes
Nov 18, 2024
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM. Indeed - no job parameter in https://github.com/kubernetes-client/python/blob/master/kubernetes/docs/BatchV1Api.md#delete_namespaced_job
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
…rgument from the k8s job client method `delete_namespaced_job` invocation (apache#44131)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix the
KubernetesJobOperatorby removing the "job" parameter from the K8s client method call (delete_namespaced_job) as it is not expected by the API. Apparently this parameter was added here by mistake.