Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Nov 14, 2024

This field (dataplex_transfer_status) got added in googleapis/google-cloud-python#13277 as part of google-cloud-datacatalog==3.22.0

Example failure: https://github.com/apache/airflow/actions/runs/11842030744/job/33000167393?pr=44036

=========================== short test summary info ============================
FAILED providers/tests/google/cloud/operators/test_datacatalog.py::TestCloudDataCatalogCreateTagTemplateOperator::test_assert_valid_hook_call - AssertionError: assert equals failed
  {                                {                               
                                     'dataplex_transfer_status': 0 
                                   ,                               
    'display_name': '',              'display_name': '',           
    'fields': {},                    'fields': {},                 
    'is_publicly_readable': False    'is_publicly_readable': False 
  ,                                ,                               
    'name': 'projects/example_id/    'name': 'projects/example_id/ 
  locations/en-west-3/tagTemplate  locations/en-west-3/tagTemplate 
  s/test-tag-template-id',         s/test-tag-template-id',        
  }                                }
====== 1 failed, 4200 passed, 79 skipped, 1 warning in 261.02s (0:04:21) =======


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@kaxil kaxil requested a review from potiuk November 14, 2024 17:54
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 14, 2024
@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

Yeah I was afraid of this - you cannot us dict in dict assert :( .

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

Python 3.9+

assert {**dict2, **dict1} == dict2

@kaxil
Copy link
Member Author

kaxil commented Nov 14, 2024

oh whoops, fixing

This field (`dataplex_transfer_status`) got added in googleapis/google-cloud-python#13277 as part of `google-cloud-datacatalog==3.22.0`
@kaxil kaxil merged commit 060f75f into apache:main Nov 14, 2024
@kaxil kaxil deleted the datacatalog branch November 14, 2024 19:34
potiuk pushed a commit to potiuk/airflow that referenced this pull request Dec 23, 2024
This field (`dataplex_transfer_status`) got added in googleapis/google-cloud-python#13277 as part of `google-cloud-datacatalog==3.22.0`

(cherry picked from commit 060f75f)
potiuk pushed a commit that referenced this pull request Dec 24, 2024
This field (`dataplex_transfer_status`) got added in googleapis/google-cloud-python#13277 as part of `google-cloud-datacatalog==3.22.0`

(cherry picked from commit 060f75f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants