Skip to content

Conversation

@romsharon98
Copy link
Contributor

@romsharon98 romsharon98 commented Nov 14, 2024

related: #43641


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the provider:cncf-kubernetes Kubernetes (k8s) provider related issues label Nov 14, 2024
@romsharon98 romsharon98 force-pushed the feature/move-decorators-to-standard-provider branch from eca5f93 to e5f6413 Compare November 17, 2024 17:39
@uranusjr
Copy link
Member

I don’t think we are moving core Airflow concepts like BaseOperator into the provider? Unless we are, at least @task should stay in core. Likely @setup and @teardown as well (since as_setup() and as_teardown() are on BaseOperator).

@romsharon98
Copy link
Contributor Author

I don’t think we are moving core Airflow concepts like BaseOperator into the provider? Unless we are, at least @task should stay in core. Likely @setup and @teardown as well (since as_setup() and as_teardown() are on BaseOperator).

But isn't @ task mean PythonOperator and therefore we want it out of Core?

@potiuk
Copy link
Member

potiuk commented Nov 28, 2024

But isn't @ task mean PythonOperator and therefore we want it out of Core?

Yeah. I also think while the base DecoratedOperator (and all in airflow/decorators/base.py) should stay in "core" - "task" and other decorators can be easily (or so I think) move to standard (unless there is a good reason not to).

BaseOperator. MappedOperator, DecoratedOperator are all "core" concepts - but @task, @task.bash etc. could be just considered as concrete implementations of those that could live in the standard provider.

@uranusjr - is there a reason why we should not move it ?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:cncf-kubernetes Kubernetes (k8s) provider related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants