Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Nov 14, 2024

Why

https://github.com/apache/airflow/actions/runs/11828396054/job/32960017155

What

build(chart): update statsd-exporter to 0.28.0 #44009


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:dev-tools area:helm-chart Airflow Helm Chart area:production-image Production image improvements and fixes labels Nov 14, 2024
@Lee-W Lee-W force-pushed the update-v2-10-test-deps branch 3 times, most recently from 78b58f0 to 20904ff Compare November 14, 2024 04:19
@Lee-W Lee-W marked this pull request as ready for review November 14, 2024 04:20
@Lee-W Lee-W force-pushed the update-v2-10-test-deps branch from 20904ff to 0d33bd6 Compare November 14, 2024 07:29
@Lee-W Lee-W marked this pull request as draft November 14, 2024 07:43
@Lee-W Lee-W changed the title build: update dependencies build(chart): update statsd-exporter to 0.28.0 Nov 14, 2024
@Lee-W Lee-W marked this pull request as ready for review November 14, 2024 07:58
@eladkal eladkal added this to the Airflow Helm Chart 1.16.0 milestone Nov 14, 2024
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a newsfragment for it, otherwise LGTM.

@Lee-W
Copy link
Member Author

Lee-W commented Nov 15, 2024

Need a newsfragment for it, otherwise LGTM.

Just added! Thanks!

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, actually, it needs to go in chart/newsfragments instead.

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(@Lee-W I'll give it a green so you can merge once you've fixed it)

@Lee-W
Copy link
Member Author

Lee-W commented Nov 15, 2024

Oops, actually, it needs to go in chart/newsfragments instead.

ah got it, didn't notice there's this folder. let me fix it now

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this PR targets v2-10-test branch?
Helm chart is released from main branch

@Lee-W
Copy link
Member Author

Lee-W commented Nov 15, 2024

Why this PR targets v2-10-test branch? Helm chart is released from main branch

Hmmm... this is just for fixing the CI failure on v2-10-test

@eladkal
Copy link
Contributor

eladkal commented Nov 15, 2024

Why this PR targets v2-10-test branch? Helm chart is released from main branch

Hmmm... this is just for fixing the CI failure on v2-10-test

Then why the newsfragment? I think me and Jed see this as feature not an internal fix to the CI.
Is this already avaliable in main branch and this is just the "chery pick" to fix the CI?

@Lee-W
Copy link
Member Author

Lee-W commented Nov 15, 2024

Why this PR targets v2-10-test branch? Helm chart is released from main branch

Hmmm... this is just for fixing the CI failure on v2-10-test

Then why the newsfragment? I think me and Jed see this as feature not an internal fix to the CI. Is this already avaliable in main branch and this is just the "chery pick" to fix the CI?

Just notice there's indeed a PR for this on the main branch #43393, but it was not backported

@Lee-W Lee-W self-assigned this Nov 15, 2024
@eladkal
Copy link
Contributor

eladkal commented Nov 16, 2024

Why this PR targets v2-10-test branch? Helm chart is released from main branch

Hmmm... this is just for fixing the CI failure on v2-10-test

Then why the newsfragment? I think me and Jed see this as feature not an internal fix to the CI. Is this already avaliable in main branch and this is just the "chery pick" to fix the CI?

Just notice there's indeed a PR for this on the main branch #43393, but it was not backported

Ok then we need this PR against v2-10-test to be only backport and new pr against main with the newsfragment

@Lee-W
Copy link
Member Author

Lee-W commented Nov 16, 2024

Why this PR targets v2-10-test branch? Helm chart is released from main branch

Hmmm... this is just for fixing the CI failure on v2-10-test

Then why the newsfragment? I think me and Jed see this as feature not an internal fix to the CI. Is this already avaliable in main branch and this is just the "chery pick" to fix the CI?

Just notice there's indeed a PR for this on the main branch #43393, but it was not backported

Ok then we need this PR against v2-10-test to be only backport and new pr against main with the newsfragment

Sounds good. Then I think I don't need to do anything for this one, but will need to create an new one to main (for newsfragment)

@Lee-W Lee-W requested a review from eladkal November 18, 2024 00:54
@eladkal eladkal removed this from the Airflow Helm Chart 1.16.0 milestone Nov 18, 2024
@eladkal
Copy link
Contributor

eladkal commented Nov 18, 2024

No need for newsfragment on this PR after the fix in main

@Lee-W Lee-W closed this Nov 18, 2024
@Lee-W Lee-W force-pushed the update-v2-10-test-deps branch from 58c053d to f787cfa Compare November 18, 2024 07:44
@Lee-W
Copy link
Member Author

Lee-W commented Nov 18, 2024

it seems to be fixed already. close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:dev-tools area:helm-chart Airflow Helm Chart area:production-image Production image improvements and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants