-
Notifications
You must be signed in to change notification settings - Fork 16.4k
build(chart): update statsd-exporter to 0.28.0 #44009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
78b58f0 to
20904ff
Compare
20904ff to
0d33bd6
Compare
jedcunningham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a newsfragment for it, otherwise LGTM.
Just added! Thanks! |
jedcunningham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, actually, it needs to go in chart/newsfragments instead.
jedcunningham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(@Lee-W I'll give it a green so you can merge once you've fixed it)
ah got it, didn't notice there's this folder. let me fix it now |
eladkal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this PR targets v2-10-test branch?
Helm chart is released from main branch
Hmmm... this is just for fixing the CI failure on |
Then why the newsfragment? I think me and Jed see this as feature not an internal fix to the CI. |
Just notice there's indeed a PR for this on the main branch #43393, but it was not backported |
Ok then we need this PR against v2-10-test to be only backport and new pr against main with the newsfragment |
Sounds good. Then I think I don't need to do anything for this one, but will need to create an new one to main (for newsfragment) |
|
No need for newsfragment on this PR after the fix in main |
58c053d to
f787cfa
Compare
|
it seems to be fixed already. close this one |
Why
https://github.com/apache/airflow/actions/runs/11828396054/job/32960017155
What
build(chart): update statsd-exporter to 0.28.0 #44009
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.