Added host_proxy_cmd field in the ssh hooks extra options #43930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Nov 28, 2024
potiuk
force-pushed
the
ssh-operator-extra-proxy-cmd
branch
from
57baa39 to
4f74c7a
Compare
Member
|
You will need to fix tests |
Contributor
|
@dominikhei can you rebase and fix the tests? |
Contributor
Author
@eladkal Thank you for the reminder. I will fix it in the next few days! |
dominikhei
force-pushed
the
ssh-operator-extra-proxy-cmd
branch
from
50d9851 to
9e41a7c
Compare
Contributor
|
Looks like this was already added in #44565 |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #43636
One can now add the key:
host_proxy_cmdto theextra_optionsof the SSHHook.This is the now preferred option of setting an external command. Only if the
host_proxy_cmdattribute of the class is not set via theextra_options, it will be read from the hosts~/.ssh/config.I have also added a unit test for the new functionality.
If there is anything I should change / add, let me know.