Fix logs with leading spaces in the Docker operator (#33692) #43840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrk-andreev
force-pushed
the
issues-33692
branch
from
90398cf to
34dc1a8
Compare
Member
potiuk
approved these changes
Nov 9, 2024
Member
|
Can you please just improve the commit message. It's ready to go otherwise |
Python 3.11’s multi-line error arrows don’t display correctly in Airflow’s DockerOperator logs due to leading spaces being removed, making error messages hard to read.
Before fix:
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^
After fix:
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^
Fixes: apache#33692
mrk-andreev
force-pushed
the
issues-33692
branch
from
34dc1a8 to
1ca428f
Compare
mrk-andreev
changed the title
Contributor
|
Thanks for fixing this! And sorry I was never able to prioritize raising a PR, my local patch of Airflow uses the same method to solve this. |
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…pache#43840) Python 3.11’s multi-line error arrows don’t display correctly in Airflow’s DockerOperator logs due to leading spaces being removed, making error messages hard to read. Before fix: return self.main(*args, **kwargs) ^^^^^^^^^^^^^^^^ After fix: return self.main(*args, **kwargs) ^^^^^^^^^^^^^^^^ Fixes: apache#33692
2 tasks
Contributor
|
FWIW, I just tested this now and it did not fix my original issue, I made a follow up issue and will try and prioritize submitting a PR: #58911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11’s multi-line error arrows don’t display correctly in Airflow’s DockerOperator logs due to leading spaces being removed, making error messages hard to read.
Before fix:
After fix:
Fixes: #33692