Fix PostgresHook bug when getting AWS Redshift Serverless credentials #43807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawwar
approved these changes
Nov 8, 2024
Contributor
Author
Thanks, the "catch" was when I shadowed this code into my org's Airflow instance and got the key error, so I found it the hard way 😅. |
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…apache#43807) * correct test value * fix production code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43669 used the wrong keys for retrieving user and password from the boto3 redshift-serverless client response, leading to
KeyErrorexceptions. This change uses the correct camel-caseddbUseranddbPasswordkeys; the boto3 redshift client response returns the Pascal-casedDbUserandDbPasswordand these were mistakenly copied into the serverless code block (and the associated test code).Unfortunately moto does not yet support redshift-serverless, which might have caught this bug in the first PR.
related: #43669