Skip to content

Conversation

@MaksYermak
Copy link
Contributor

In this PR I have updated the namespace priority for the find_pod function. Because we faced the bug, in case when the user specified namespace in the task and inside the metadata for pod_request_obj user has a different namespace. Then namespace will be overwritten by the value which is specified in the task. This priority looks incorrect, because in the find_pod function we need to find a Pod which has already started. And information about this Pod inside the pod_request_obj variable. It means that firstly we need to check value in pod_request_obj.metadata.namespace and, then, value inside self.namespace.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Nov 6, 2024
@MaksYermak MaksYermak force-pushed the change-namespace-priority branch from 0483dda to 15095a3 Compare November 12, 2024 10:38
@MaksYermak MaksYermak force-pushed the change-namespace-priority branch from 15095a3 to fed0705 Compare November 12, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants