bugfix description should be optional for openlineage integration with AthenaOperator
#43576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nlineage behavior for AthenaOperator.
boring-cyborg
bot
added
area:providers
provider:amazon
Contributor
Author
|
@eladkal @o-nikolas pls review, linter fixed |
o-nikolas
reviewed
Nov 1, 2024
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
Is there a test that should be added to ensure no regression again? I haven't touched the openlineage stuff much so I'm not sure what the testing is like
Contributor
Author
|
@o-nikolas sorry, i am not able to write proper test for this, i’m not aware of how to write tests for airflow operators 😔. I could only provide queries for tests. |
Member
|
Just look at the other tests implemented and extend them appropriately. They are pretty logical:
|
vincbeck
approved these changes
Nov 4, 2024
eladkal
changed the title
AthenaOperator
mobuchowski
approved these changes
Nov 6, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…h `AthenaOperator` (apache#43576) * Comments are optional for athena table columns. This change fixes openlineage behavior for AthenaOperator. * Fix linter * Fix linter v2 and just revert changes for description * Fix athena metadata - comments to fields are optional. * Fix expected mock result --------- Co-authored-by: Bohdan Udovenko <bohdan.udovenko@raiffeisen.ua>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments are optional for athena table columns. This change fixes openlineage behavior for AthenaOperator.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.