Skip to content

Mark all tasks as skipped when failing a dag_run manually including t… #43482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ashb merged 5 commits into from
Oct 29, 2024
Merged

Mark all tasks as skipped when failing a dag_run manually including t… #43482

ashb merged 5 commits into from
Oct 29, 2024

Conversation

@abhishekbhakat
Copy link
Contributor

@abhishekbhakat abhishekbhakat commented Oct 29, 2024

closes: #43475

There no reason to leave any task as None state when marking the dag_run as failed manually.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Oct 29, 2024
ashb
ashb reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you add a unit test for this though please?

@ashb ashb added this to the Airflow 2.10.3 milestone Oct 29, 2024
@abhishekbhakat
Copy link
Contributor Author

abhishekbhakat commented Oct 29, 2024

Looks good. Could you add a unit test for this though please?

Done. Added a test which will fail without the code changes like:

=============================================================================== short test summary info ================================================================================
FAILED tests/www/views/test_views_dagrun.py::test_dagrun_failed - AssertionError: assert None in {'failed', 'skipped', 'success', 'upstream_failed'}
 +  where None = <TaskInstance: example_bash_decorator.run_this_last test_dagrun_failed [None]>.state
============================================================================= 1 failed, 1 warning in 6.21s =============================================================================
root@b8d8405b20f5:/opt/airflow# python -m pytest -vvv tests/www/views/test_views_dagrun.py::test_dagrun_failed
================================================================================= test session starts ==================================================================================

@ashb ashb merged commit eda6a8f into apache:main Oct 29, 2024
@potiuk potiuk modified the milestones: Airflow 2.11.0, Airflow 2.10.3 Oct 31, 2024
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Nov 1, 2024
@abhishekbhakat @utkarsharma2
Mark all tasks as skipped when failing a dag_run manually including t…
2fd245d 
…asks with None state (apache#43482)

(cherry picked from commit eda6a8f)
@utkarsharma2 utkarsharma2 mentioned this pull request Nov 1, 2024
Merged
@utkarsharma2
Copy link
Contributor

utkarsharma2 commented Nov 1, 2024

Backported to v2-10-test in PR - #43572

utkarsharma2 added a commit that referenced this pull request Nov 1, 2024
@utkarsharma2 @abhishekbhakat
Mark all tasks as skipped when failing a dag_run manually including t… (
72eef0f 
#43572)

* Mark all tasks as skipped when failing a dag_run manually including tasks with None state (#43482)

(cherry picked from commit eda6a8f)

* Fix tests for 2.10.x

---------

Co-authored-by: Abhishek <abhishek.bhakat@hotmail.com>
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Nov 1, 2024
utkarsharma2 added a commit that referenced this pull request Nov 1, 2024
@utkarsharma2 @abhishekbhakat
Mark all tasks as skipped when failing a dag_run manually including t… (
b8ab1cc 
#43572)

* Mark all tasks as skipped when failing a dag_run manually including tasks with None state (#43482)

(cherry picked from commit eda6a8f)

* Fix tests for 2.10.x

---------

Co-authored-by: Abhishek <abhishek.bhakat@hotmail.com>
(cherry picked from commit 72eef0f)
utkarsharma2 added a commit that referenced this pull request Nov 1, 2024
@utkarsharma2 @abhishekbhakat
Mark all tasks as skipped when failing a dag_run manually including t… (
7970a46 
#43572)

* Mark all tasks as skipped when failing a dag_run manually including tasks with None state (#43482)

(cherry picked from commit eda6a8f)

* Fix tests for 2.10.x

---------

Co-authored-by: Abhishek <abhishek.bhakat@hotmail.com>
(cherry picked from commit 72eef0f)
utkarsharma2 added a commit that referenced this pull request Nov 1, 2024
@utkarsharma2 @abhishekbhakat
Mark all tasks as skipped when failing a dag_run manually including t… (
186619a 
#43572)

* Mark all tasks as skipped when failing a dag_run manually including tasks with None state (#43482)

(cherry picked from commit eda6a8f)

* Fix tests for 2.10.x

---------

Co-authored-by: Abhishek <abhishek.bhakat@hotmail.com>
(cherry picked from commit 72eef0f)
utkarsharma2 added a commit that referenced this pull request Nov 1, 2024
@utkarsharma2 @abhishekbhakat
Mark all tasks as skipped when failing a dag_run manually including t… (
7e86bf8 
#43572)

* Mark all tasks as skipped when failing a dag_run manually including tasks with None state (#43482)

(cherry picked from commit eda6a8f)

* Fix tests for 2.10.x

---------

Co-authored-by: Abhishek <abhishek.bhakat@hotmail.com>
(cherry picked from commit 72eef0f)
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@abhishekbhakat @ellisms
Mark all tasks as skipped when failing a dag_run manually including t…
3ac31b6 
…asks with None state (apache#43482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashb ashb ashb approved these changes

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API type:bug-fix Changelog: Bug Fixes

Projects

None yet

Milestone

Airflow 2.10.3

Development

Successfully merging this pull request may close these issues.

Trigger Rule all_done does not honor the dag_run marked failed manually and brings back the dag_run to running.

5 participants

@abhishekbhakat @utkarsharma2 @ashb @potiuk @phanikumv