Skip to content

Conversation

@childe
Copy link
Contributor

@childe childe commented Oct 29, 2024

HttpHooK.run() accepts request_kwargs, however HttpOperator and HttpSensor do not pass request_kwargs to HttpHooK.run()

HttpHooK.run() accepts request_kwargs, however HttpOperator and HttpSensor
do not pass request_kwargs to HttpHooK.run()
Copy link
Contributor

@romsharon98 romsharon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@potiuk potiuk merged commit fba1770 into apache:main Oct 29, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 29, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Fix(http) bug, pass request_kwargs to HttpHooK.run

HttpHooK.run() accepts request_kwargs, however HttpOperator and HttpSensor
do not pass request_kwargs to HttpHooK.run()

* Format code for Ruff.format static check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants