Feature: Added fast_executemany parameter to insert_rows of DbApiHook #43357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Oct 24, 2024
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Nice. A bit of hack but should work perfectly well.
Member
|
But our very diligent bot is not happy with spelling in the docs ... You can put |
hussein-awala
approved these changes
Oct 25, 2024
83 tasks
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…apache#43357) * refactor: Added the fast_executemany parameter to the insert_rows method of the DbApiHook * refactor: Added unit test using the fast_executemany parameter in the DbApiHook * docs: Put fast_executemany and executemany between single quotes to avoid spelling check --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in my blogpost using the GenericTransfer operator, I've patched the insert_rows method of the DbApiHook to allow specifying the fast_executemany parameter from the GenericTransfer operator to allow much faster executemany when inserting rows into the destination database. The insert_rows method behaves as before if the parameter isn't specified (False by default). This is one of the patches that will be needed to enhance the GenericTransfer, once this PR is merged I will create a new one for the GenericTransfer operator itself and the SQLExecuteQueryTrigger.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.