Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Oct 22, 2024

Without this tmux runs fine, but when you exit, you see the following:

root@7baa3481ecf9:/opt/airflow# scripts/in_container/bin/run_tmux
can't find pane: 2
[exited]

That is because we are trying to select a pane that doesn't exist yet. This might have been an unintentional error while adding more panes in #41896


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Without this tmux runs fine, but when you exit, you see the following:

```
root@7baa3481ecf9:/opt/airflow# scripts/in_container/bin/run_tmux
can't find pane: 2
[exited]
```

That is because we are trying to select a pane that doesn't exist yet.
@kaxil kaxil requested review from ashb and potiuk as code owners October 22, 2024 02:09
@kaxil kaxil added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 22, 2024
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw it too. LGTM +1
image

@kaxil kaxil merged commit d122ebf into apache:main Oct 22, 2024
@kaxil kaxil deleted the tmux-fix branch October 22, 2024 09:07
@potiuk
Copy link
Member

potiuk commented Oct 22, 2024

Nice!

harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants