Temporarily limits WTForms to below 3.2.0 #43233 #43234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WTForms are limited to 3.2.0 because of the error in tests. We technically do not need it directly as this is a dependency of Flask-WTF, but we need to specify it here to add the limitation The issue to track it is https://github.com/pallets-eco/wtforms/issues/863 Note. 3.2.0 has been broken because of imports pallets-eco/wtforms#861 which was fixed in 3.2.1, but after import was fixed, the tests started to work with 3.2.1 when the issue 863 is fixed, we should likely leave the line below and specify !=3.2.0,!=3.2.1 (cherry picked from commit 979d750)
kaxil
approved these changes
Oct 21, 2024
utkarsharma2
added
the
type:misc/internal
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
WTForms are limited to 3.2.0 because of the error in tests. We technically do not need it directly as this is a dependency of Flask-WTF, but we need to specify it here to add the limitation The issue to track it is https://github.com/pallets-eco/wtforms/issues/863 Note. 3.2.0 has been broken because of imports pallets-eco/wtforms#861 which was fixed in 3.2.1, but after import was fixed, the tests started to work with 3.2.1 when the issue 863 is fixed, we should likely leave the line below and specify !=3.2.0,!=3.2.1 (cherry picked from commit 979d750) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
utkarsharma2
added
changelog:skip
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
WTForms are limited to 3.2.0 because of the error in tests. We technically do not need it directly as this is a dependency of Flask-WTF, but we need to specify it here to add the limitation The issue to track it is https://github.com/pallets-eco/wtforms/issues/863 Note. 3.2.0 has been broken because of imports pallets-eco/wtforms#861 which was fixed in 3.2.1, but after import was fixed, the tests started to work with 3.2.1 when the issue 863 is fixed, we should likely leave the line below and specify !=3.2.0,!=3.2.1 (cherry picked from commit 979d750) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-port of #43233 to v2-10-test