Skip to content

fix mypy failure(provider) in SqlSensor #43206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 3 commits into from
Oct 26, 2024
Merged

fix mypy failure(provider) in SqlSensor #43206

potiuk merged 3 commits into from
Oct 26, 2024

Conversation

@rawwar
Copy link
Contributor

@rawwar rawwar commented Oct 21, 2024

when I run pre-commit run --all-files, I get the following mypy failure:

providers/src/airflow/providers/common/sql/sensors/sql.py:110: error: "None"
not callable  [misc]
            condition = self.selector(records[0])

This PR fixes it.

@rawwar rawwar marked this pull request as ready for review October 26, 2024 10:46
@rawwar rawwar requested review from Lee-W and potiuk October 26, 2024 10:46
@potiuk potiuk merged commit a700382 into apache:main Oct 26, 2024
@eladkal eladkal mentioned this pull request Oct 27, 2024
Closed
83 tasks
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@rawwar @ellisms
fix mypy failure (apache#43206)
e4f9ea6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@Lee-W Lee-W Awaiting requested review from Lee-W

Assignees

No one assigned

Labels

area:providers provider:common-sql

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rawwar @potiuk