Add TimeoutError to be a retryable error in databricks provider #43137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lucafurrer , FYI |
pankajkoti
reviewed
Oct 18, 2024
Member
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
If ServerTimeoutError extends TimeoutError, we should check for TimeoutError instead. It works the other way round than what we're saying the description🙂
This comment was marked as off-topic.
This comment was marked as off-topic.
Lee-W
approved these changes
Oct 18, 2024
pankajkoti
approved these changes
Oct 18, 2024
rawwar
deleted the
kalyan/providers/databricks/retryable_timeout_error
branch
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
83 tasks
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43128
aiohttp.client_exception.ServerTimeoutErrorextendsasyncio.exceptions.TimeoutError. Hence, usedServerTimeoutErrorwhen checking for type using isinstance. That should coverTimeoutError