Migrate health info to fastapi #42938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:API
There was a problem hiding this comment.
Looking nice.
Ideally we could add a test. I know they are a little bit more complicated because you need some jobs to be created. A good compromise could be to simply mock the get_airflow_health() with dummy results and check that the route returns what is expected.
pierrejeambrun
added
the
legacy api
bbovenzi
force-pushed
the
fastapi-add-health-info
branch
from
a7c767d
to
f946047
Compare
jscheffl
approved these changes
Oct 15, 2024
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
* Add health info to public fastapi * Add test and fix TaskInstanceState name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate /health to fastapi public api under a monitor router
Closes #42937
Part of #42370
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.