Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conn id parameters templated in GenericTransfer and also allow passing hook parameters like in BaseSQLOperator #42891

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

dabla
Copy link
Contributor

@dabla dabla commented Oct 10, 2024

Today I've discovered that the conn id parameters (source_conn_id and destination_conn_id) aren't templated in the GenericTransfer. This PR will also allow passing hook parameters like in BaseSQLOperator. Refactored the get_hook method in BaseOperator so that in the future it can be used in a generic way, added tests to remove backward compatibility code for Airflow 2.8.x once min version of provider is Aiflow 3.0.0 or higher.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

…conn_id's for GenericTransfer and also allow passing hook params for each connection in GenericTransfer
@boring-cyborg boring-cyborg bot added area:core-operators Operators, Sensors and hooks within Core Airflow area:providers provider:common-sql labels Oct 10, 2024
@potiuk
Copy link
Member

potiuk commented Oct 14, 2024

Looks like there is some problem with minimum version of one of microsoft dependencies. Bringing it down, brings opentelemetry dependency down and this seems to break imports. Unfold the failng test output for microsoft.azure and you will see it:

https://github.com/apache/airflow/actions/runs/11299097052/job/31429704576?pr=42891#step:7:6196

@dabla
Copy link
Contributor Author

dabla commented Oct 14, 2024

Looks like there is some problem with minimum version of one of microsoft dependencies. Bringing it down, brings opentelemetry dependency down and this seems to break imports. Unfold the failng test output for microsoft.azure and you will see it:

https://github.com/apache/airflow/actions/runs/11299097052/job/31429704576?pr=42891#step:7:6196

Seems to be fine now after I updated the branch

@potiuk
Copy link
Member

potiuk commented Oct 14, 2024

There are some compatibility Airflow 3 / Airflow 2 issues that need to be addressed :)

@dabla
Copy link
Contributor Author

dabla commented Oct 17, 2024

There are some compatibility Airflow 3 / Airflow 2 issues that need to be addressed :)

All issues fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow area:providers provider:common-sql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants