AIP-84 Migrate the public endpoint Get DAG to FastAPI #42848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkar-foss
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
|
Also can you double check that aliases are correctly documented in the specification (generated yaml / swagger). Because I had an issue earlier when experimenting with them. |
Yes, all 3 aliases seem to be correctly documented in the generated yaml as well as swagger. Line numbers for your quick reference as follows: |
pierrejeambrun
approved these changes
Oct 10, 2024
kunaljubce
pushed a commit
to kunaljubce/airflow
that referenced
this pull request
Oct 13, 2024
* Migrate the public endpoint Get DAG to FastAPI * Use proper name for test function
pavansharma36
pushed a commit
to pavansharma36/airflow
that referenced
this pull request
Oct 14, 2024
* Migrate the public endpoint Get DAG to FastAPI * Use proper name for test function
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
* Migrate the public endpoint Get DAG to FastAPI * Use proper name for test function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #42652
related: #42370
This migrates the Get DAG API from
api_connexiontoapi_fastapi, with a supporting test.Additionally, this replaces
AliasChoiceswith a singleAliasGenerator. The lowest direct dependency resolution tests that were previously failing forAliasGeneratorwill now pass, thanks to the Pydantic min version update in #42694.