Skip to content

Fix mark as success when pod fails while fetching log #42815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Oct 9, 2024
Merged

Fix mark as success when pod fails while fetching log #42815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c96b6dc
fix: always defer once more after log fetching to ensure pod completi…
peloyeje Jul 19, 2024
2eb8754
add tests
romsharon98 Oct 8, 2024
d060f68
removing print
romsharon98 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions airflow/providers/cncf/kubernetes/operators/pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,9 +790,7 @@ def trigger_reentry(self, context: Context, event: dict[str, Any]) -> Any:
since_time=last_log_time,
)

if pod_log_status.running:
self.log.info("Container still running; deferring again.")
self.invoke_defer_method(pod_log_status.last_log_time)
self.invoke_defer_method(pod_log_status.last_log_time)
else:
self.invoke_defer_method()

Expand Down
12 changes: 12 additions & 0 deletions tests/providers/cncf/kubernetes/operators/test_pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1780,6 +1780,18 @@ def test_process_duplicate_label_pods__pod_removed_if_delete_pod(
process_pod_deletion_mock.assert_called_once_with(pod_1)
assert result.metadata.name == pod_2.metadata.name

@patch(POD_MANAGER_CLASS.format("fetch_container_logs"))
@patch(KUB_OP_PATH.format("invoke_defer_method"))
def test_defere_call_one_more_time_after_error(self, invoke_defer_method, fetch_container_logs):
fetch_container_logs.return_value = PodLoggingStatus(False, None)
op = KubernetesPodOperator(task_id="test_task", name="test-pod", get_logs=True)

op.trigger_reentry(
create_context(op), event={"name": TEST_NAME, "namespace": TEST_NAMESPACE, "status": "running"}
)

invoke_defer_method.assert_called_with(None)


class TestSuppress:
def test__suppress(self, caplog):
Expand Down