-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84 Migrate get connections to FastAPI API #42571 #42782
AIP-84 Migrate get connections to FastAPI API #42571 #42782
Conversation
Could someone please include |
done.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we need the model
for the default fallback Model to look for columns.
Few minor suggestions.
…ections endpoint to fastapi
…ss already have abstract
…strategy for backcompat
…removed unnecessary attribute mapping keys
90b4f4c
to
b1a0c9f
Compare
I just rebased the branch and resolved merge conflicts. I think we are good to go. |
Merging because we need that for other PRs. (dynamic order_by). We can adjust with following PR if needed. |
Make sense! I don't want to block anyone in the development flow. At least, you have already driven it and finalised the work so that it didn't block anyone for a long time. |
) * Make SortParam parent for Model Specific SortParams, Include get connections endpoint to fastapi * Change depends() method regular method in SortParam due to parent class already have abstract * Remove subclass, get default order_by from primary key, change alias strategy for backcompat * pre-commit hooks * Dynamic return value of SortParam generated within openapi specs and removed unnecessary attribute mapping keys * Include connection_id to attr_mapping again * Dynamic depends with correct documentation * Add more tests --------- Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
closes: #42591
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.