Skip to content

Conversation

@gopidesupavan
Copy link
Member

Canary build failed for test_cli_internal_api_background
https://github.com/apache/airflow/actions/runs/11195761491/job/31123900258#step:7:3096

Adding small fix to terminate both monitor and api pids.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@gopidesupavan gopidesupavan changed the title Fix test_cli_internal_api_background process termination Fix canary build test test_cli_internal_api_background process termination Oct 5, 2024
@jscheffl jscheffl force-pushed the fix-flaky-test-background-proces branch from 72c517c to f737773 Compare October 6, 2024 09:49
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure is rather from PR #42686 and this is a good improvement in my view. Therefore going to merge

@jscheffl jscheffl merged commit face62b into apache:main Oct 6, 2024
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@gopidesupavan gopidesupavan deleted the fix-flaky-test-background-proces branch November 23, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants