AIP-65: Track the serialized DAG across DagRun & TaskInstance #42690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:db-migrations
ephraimbuddy
force-pushed
the
track-serdag-version
branch
from
f53fadf
to
b1ce903
Compare
ephraimbuddy
changed the title
ephraimbuddy
force-pushed
the
track-serdag-version
branch
7 times, most recently
from
38ef224
to
e57ea73
Compare
This commit adds versioning to the serializedDagModel. Changes: Added new columns, id, and version_number to the SDM and made id the primary key. Updated the write_dag method of the SDM to add the SDs correctly. Updated the queries so the scheduler/webserver runs with the latest SDM The version_number was added to help us track the evolution of a DAG. Suppose a DAG with dag_hash AB is changed, and the dag_hash becomes CD. If the change is reverted, we will have a dag_hash of AB again. In this case, the version_number would still increment, letting us know that the DAG was changed three times. I feel it's a meaningful way to track the changes, independent of the id column, which is database internals.
This helps to track the serialized DAG version the task instance ran with by establishing a relationship between the entities instead of using the dag_hash.
ephraimbuddy
force-pushed
the
track-serdag-version
branch
from
e57ea73
to
9c5ea0d
Compare
ephraimbuddy
requested review from
potiuk,
ashb and
ryanahamilton
as code owners
ephraimbuddy
requested review from
bbovenzi,
pierrejeambrun,
jscheffl,
kaxil,
bolkedebruin and
XD-DENG
as code owners
1 task
|
Closing in preference of #42913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #42547
This helps to track the serialized DAG version the task instance ran
with, by establishing a relationship between the entities instead of using
the dag_hash.
Only the last commit is relevant