feat: allow customizing podManagementPolicy #42673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvertonSA
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
edumueller
approved these changes
Oct 3, 2024
Contributor
Author
|
thank you so much for the help here @eladkal, at my organization, we recently pushed celery to production and at the moment we are having issues on scaling due to high termination grace period. |
potiuk
approved these changes
Oct 4, 2024
Member
|
cc: @jedcunningham for cross-check |
romsharon98
approved these changes
Oct 8, 2024
Contributor
|
Already merged but it will be nice if you add a UT for this 🙂 |
Contributor
Author
|
hi @romsharon98 , I beg your pardon, what is a UT? I will add it |
Contributor
in UT I ment unit tests. |
kunaljubce
pushed a commit
to kunaljubce/airflow
that referenced
this pull request
Oct 13, 2024
* feat: allow customizing podManagementPolicy * fix: adjust schema and identation * ci: adjust lint --------- Co-authored-by: Arakaki, Everton <everton.arakaki@rabobank.nl>
pavansharma36
pushed a commit
to pavansharma36/airflow
that referenced
this pull request
Oct 14, 2024
* feat: allow customizing podManagementPolicy * fix: adjust schema and identation * ci: adjust lint --------- Co-authored-by: Arakaki, Everton <everton.arakaki@rabobank.nl>
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* feat: allow customizing podManagementPolicy * fix: adjust schema and identation * ci: adjust lint --------- Co-authored-by: Arakaki, Everton <everton.arakaki@rabobank.nl>
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
* feat: allow customizing podManagementPolicy * fix: adjust schema and identation * ci: adjust lint --------- Co-authored-by: Arakaki, Everton <everton.arakaki@rabobank.nl>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* feat: allow customizing podManagementPolicy * fix: adjust schema and identation * ci: adjust lint --------- Co-authored-by: Arakaki, Everton <everton.arakaki@rabobank.nl>
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I as a user of StatefulSets in Airflow, would like to preserving workload uniqueness and identity guarantees, but allow scalling up and down without waiting for termination grace period.
This is useful when termination grace period is very high. In such cases, scaling up and down gets fully stuck while waiting for long running tasks.