Skip to content

Make private_key_content a sensitive field in Snowflake connection #42649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 8 commits into from
Oct 2, 2024
Merged

Make private_key_content a sensitive field in Snowflake connection #42649

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
616aeea
use PasswordField
rawwar Oct 2, 2024
43dd482
Merge branch 'main' of https://github.com/apache/airflow into kalyan/…
rawwar Oct 2, 2024
81d13ac
Merge branch 'main' into kalyan/providers/snowflake/hide_private_key
rawwar Oct 2, 2024
e96c9b7
Merge branch 'kalyan/providers/snowflake/hide_private_key' of github.…
rawwar Oct 2, 2024
83b27a3
use PasswordField
rawwar Oct 2, 2024
fb57518
Merge branch 'main' into kalyan/providers/snowflake/hide_private_key
rawwar Oct 2, 2024
9150e5d
Merge branch 'main' into kalyan/providers/snowflake/hide_private_key
rawwar Oct 2, 2024
836b268
Merge branch 'main' into kalyan/providers/snowflake/hide_private_key
rawwar Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions airflow/providers/snowflake/hooks/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,12 @@ class SnowflakeHook(DbApiHook):
@classmethod
def get_connection_form_widgets(cls) -> dict[str, Any]:
"""Return connection widgets to add to connection form."""
from flask_appbuilder.fieldwidgets import BS3TextAreaFieldWidget, BS3TextFieldWidget
from flask_appbuilder.fieldwidgets import (
BS3PasswordFieldWidget,
BS3TextFieldWidget,
)
from flask_babel import lazy_gettext
from wtforms import BooleanField, StringField
from wtforms import BooleanField, PasswordField, StringField

return {
"account": StringField(lazy_gettext("Account"), widget=BS3TextFieldWidget()),
Expand All @@ -107,8 +110,8 @@ def get_connection_form_widgets(cls) -> dict[str, Any]:
"region": StringField(lazy_gettext("Region"), widget=BS3TextFieldWidget()),
"role": StringField(lazy_gettext("Role"), widget=BS3TextFieldWidget()),
"private_key_file": StringField(lazy_gettext("Private key (Path)"), widget=BS3TextFieldWidget()),
"private_key_content": StringField(
lazy_gettext("Private key (Text)"), widget=BS3TextAreaFieldWidget()
"private_key_content": PasswordField(
lazy_gettext("Private key (Text)"), widget=BS3PasswordFieldWidget()
),
"insecure_mode": BooleanField(
label=lazy_gettext("Insecure mode"), description="Turns off OCSP certificate checks"
Expand Down