Remove callable functions parameter from kafka operator template_fields #42555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #42502
The Kafka ConsumeFromTopicOperator and ProduceToTopicOperator are failing to resolve callable template fields. For a callable to work with template functions, it must accept both the context and jinja_env.
If we include
producer_functionandapply_functionin the template fields, all current users will need to modify their scripts to accept bothcontextandjinja_env. and some minor updates require in kafka operator.I also tested another scenario where the function does accept context and jinja_env, but in the UI template field, it appears as a generated type object(please check below screenshot). Since there isn’t much value in displaying this field as a generated type object, I believe it's better to remove these from the template fields altogether.
Any other suggestion please?
Removed the fields and executed kafka system test.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.