BUGFIX: Paginated results in MSGraphAsyncOperator #42414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… last MSGraph calls occurs we get the all pages instead of only the last one
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
… that XCom's get fetched each time
eladkal
approved these changes
Sep 25, 2024
96 tasks
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* fix: Make sure that when paginated results are returned that when the last MSGraph calls occurs we get the all pages instead of only the last one * refactor: Refactored paginate function and added context parameter so that XCom's get fetched each time * refactor: Added unit tests for paginate function * refactor: Reformatted code like recommended by static checks * refactor: Added missing white line MSGraphAsyncOperator test * refactor: Changed keyword arguments to regular ones for calling pagination function --------- Co-authored-by: David Blain <david.blain@infrabel.be>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* fix: Make sure that when paginated results are returned that when the last MSGraph calls occurs we get the all pages instead of only the last one * refactor: Refactored paginate function and added context parameter so that XCom's get fetched each time * refactor: Added unit tests for paginate function * refactor: Reformatted code like recommended by static checks * refactor: Added missing white line MSGraphAsyncOperator test * refactor: Changed keyword arguments to regular ones for calling pagination function --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I discovered a regression in the pagination code which stores the paged results through XCom's, this PR fixes the bug.
The actual tests didn't detect the bug due to the fact that the paged results where stored in a field of the operator, but in reality each paged results will be handled by a different worker in Airflow thus a possible different instance of the operator.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.