Skip to content

Changed type hinting for handler function #42275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romsharon98 merged 16 commits into from
Sep 22, 2024
Merged

Changed type hinting for handler function #42275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e29f3d6
Changed type hinting for handler function
Ariel2400 Sep 17, 2024
fade82e
Fixed ruff type hinting
Ariel2400 Sep 17, 2024
fc49d9f
Changed from iterable to list
Ariel2400 Sep 17, 2024
3aa4956
Update sql.pyi for IDE support
Ariel2400 Sep 17, 2024
65cb669
Complied to the fetch_all_handler signature
Ariel2400 Sep 17, 2024
32e124a
Changed signature in pyi
Ariel2400 Sep 17, 2024
7725804
Fixed import error
Ariel2400 Sep 17, 2024
c224e3d
Fixed missing import
Ariel2400 Sep 17, 2024
4b85b71
Reordered imports
Ariel2400 Sep 17, 2024
6dd5f85
Reordered imports
Ariel2400 Sep 17, 2024
2638df4
Removed plus sign
Ariel2400 Sep 18, 2024
de60b4c
Removed plus sign
Ariel2400 Sep 18, 2024
d8983e9
Conformed to pep8
Ariel2400 Sep 18, 2024
220e6ae
Update sql.pyi
Ariel2400 Sep 18, 2024
271e987
Fixed bad type error
Ariel2400 Sep 18, 2024
b579a13
Update sql.pyi
romsharon98 Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/providers/common/sql/operators/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def __init__(
sql: str | list[str],
autocommit: bool = False,
parameters: Mapping | Iterable | None = None,
handler: Callable[[Any], Any] = fetch_all_handler,
handler: Callable[[Any], list[tuple] | None] = fetch_all_handler,
conn_id: str | None = None,
database: str | None = None,
split_statements: bool | None = None,
Expand Down
2 changes: 1 addition & 1 deletion airflow/providers/common/sql/operators/sql.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class SQLExecuteQueryOperator(BaseSQLOperator):
sql: str | list[str],
autocommit: bool = False,
parameters: Mapping | Iterable | None = None,
handler: Callable[[Any], Any] = ...,
handler: Callable[[Any], list[tuple] | None] = ...,
conn_id: str | None = None,
database: str | None = None,
split_statements: bool | None = None,
Expand Down