Skip to content

metrics timing consistency unit tests update #42267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romsharon98 merged 1 commit into from
Sep 17, 2024
Merged

metrics timing consistency unit tests update #42267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions tests/core/test_otel_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,13 +294,21 @@ def test_timer_with_name_returns_float_and_stores_value(self, mock_time, metrics
name=full_name(name), callbacks=ANY
)

@pytest.mark.parametrize(
"metrics_consistency_on",
[True, False],
)
@mock.patch.object(time, "perf_counter", side_effect=[0.0, 3.14])
def test_timer_no_name_returns_float_but_does_not_store_value(self, mock_time, name):
def test_timer_no_name_returns_float_but_does_not_store_value(
self, mock_time, metrics_consistency_on, name
):
protocols.metrics_consistency_on = metrics_consistency_on
with self.stats.timer() as timer:
pass

assert isinstance(timer.duration, float)
assert timer.duration == 3.14
expected_duration = 3140.0 if metrics_consistency_on else 3.14
assert timer.duration == expected_duration
assert mock_time.call_count == 2
self.meter.get_meter().create_observable_gauge.assert_not_called()

Expand All @@ -326,15 +334,24 @@ def test_timer_start_and_stop_manually_send_false(self, mock_time, metrics_consi
assert mock_time.call_count == 2
self.meter.get_meter().create_observable_gauge.assert_not_called()

@pytest.mark.parametrize(
"metrics_consistency_on",
[
True,
False,
],
)
@mock.patch.object(time, "perf_counter", side_effect=[0.0, 3.14])
def test_timer_start_and_stop_manually_send_true(self, mock_time, name):
def test_timer_start_and_stop_manually_send_true(self, mock_time, metrics_consistency_on, name):
protocols.metrics_consistency_on = metrics_consistency_on
timer = self.stats.timer(name)
timer.start()
# Perform some task
timer.stop(send=True)

assert isinstance(timer.duration, float)
assert timer.duration == 3.14
expected_value = 3140.0 if metrics_consistency_on else 3.14
assert timer.duration == expected_value
assert mock_time.call_count == 2
self.meter.get_meter().create_observable_gauge.assert_called_once_with(
name=full_name(name), callbacks=ANY
Expand Down