Skip to content

Conversation

@olegkachur-e
Copy link
Contributor

  • Label deprecated items with deprecated decorator.
  • Refactor vertex_ai AutoMLHook.create_auto_ml_text_training_job, to avoid calling get_auto_ml_text_training_job, to not trigger mypy errors after applying @deprecate on hook method.
  • Update docs.
  • Delete irrelevant system tests.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 self-requested a review September 17, 2024 11:53
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails due to missing tests (tests/always/test_project_structure.py::TestGoogleProviderProjectStructure::test_missing_examples):
https://github.com/apache/airflow/actions/runs/10882291445/job/30239557235?pr=42251

@olegkachur-e olegkachur-e force-pushed the deprecate/vertex_automl_text branch from 4a9203d to 8286125 Compare September 17, 2024 14:04
@olegkachur-e
Copy link
Contributor Author

CI fails due to missing tests (tests/always/test_project_structure.py::TestGoogleProviderProjectStructure::test_missing_examples): https://github.com/apache/airflow/actions/runs/10882291445/job/30239557235?pr=42251

Thanks for highlighting this, as we deprecate this operator, added it to the DEPRECATED_CLASSES.

@olegkachur-e olegkachur-e force-pushed the deprecate/vertex_automl_text branch from 8286125 to 332fc85 Compare September 17, 2024 14:15
- Label deprecated items with deprecated decorator.
- Refactor vertex_ai AutoMLHook.create_auto_ml_text_training_job, to
  avoid calling get_auto_ml_text_training_job, to not trigger mypy
errors after applying @deprecate on hook method.
- Update docs.
- Delete irrelevant system tests.
@olegkachur-e olegkachur-e force-pushed the deprecate/vertex_automl_text branch from 332fc85 to 5986b77 Compare September 18, 2024 14:05
@shahar1 shahar1 merged commit d734381 into apache:main Sep 19, 2024
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
- Label deprecated items with deprecated decorator.
- Refactor vertex_ai AutoMLHook.create_auto_ml_text_training_job, to
  avoid calling get_auto_ml_text_training_job, to not trigger mypy
errors after applying @deprecate on hook method.
- Update docs.
- Delete irrelevant system tests.

Co-authored-by: Oleg Kachur <kachur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants