ECS Exec: Drop params that aren't compatible with EC2 #42228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using the ECS executor with the EC2 launch type, then platform_version and assign_public_ip are not applicable and cause the Boto call to fail.
boring-cyborg
bot
added
area:providers
provider:amazon
eladkal
approved these changes
Sep 13, 2024
hussein-awala
approved these changes
Sep 13, 2024
vincbeck
deleted the
onikolas/ecs_exec_ec2_launch_type_platform_version
branch
gopidesupavan
pushed a commit
to gopidesupavan/airflow
that referenced
this pull request
Sep 17, 2024
If using the ECS executor with the EC2 launch type, then platform_version and assign_public_ip are not applicable and cause the Boto call to fail.
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
If using the ECS executor with the EC2 launch type, then platform_version and assign_public_ip are not applicable and cause the Boto call to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using the ECS executor with the EC2 launch type, then platform_version and assign_public_ip are not applicable and cause the Boto call to fail.
fixes #41824
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.