Fix consistent return response from PubSubPullSensor #42080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
gopidesupavan
commented
Sep 7, 2024
MaksYermak
suggested changes
Sep 9, 2024
gopidesupavan
force-pushed
the
fix-consistent-return-response-in-pubsubpullsensor
branch
from
681799f to
111c632
Compare
Lee-W
reviewed
Sep 23, 2024
Lee-W
reviewed
Sep 23, 2024
Lee-W
reviewed
Sep 23, 2024
Lee-W
approved these changes
Sep 24, 2024
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Looks great! Thanks for making the immediate modifications.
Member
|
One thing I just think of @eladkal do you think it's a breaking change? as we change the trigger here |
potiuk
approved these changes
Oct 2, 2024
Member
IMHO we can treat it as a bugfix. |
Member
|
But it would be nice to add a note at the top of the CHANGELOG explaining the change expected. |
Member
|
Yep, it sounds more like a bug fix to me, but I would like to be cautious. I'll merge it later today if no one object. |
96 tasks
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* fix consistent return response pubsubsensor * removed messages_callback argument to pubsub trigger and using it in execute_complete * updated variable name * updates as per comments, added return types and refactored logic * update types, tests and use inherit exception
gopidesupavan
deleted the
fix-consistent-return-response-in-pubsubpullsensor
branch
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* fix consistent return response pubsubsensor * removed messages_callback argument to pubsub trigger and using it in execute_complete * updated variable name * updates as per comments, added return types and refactored logic * update types, tests and use inherit exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #41877
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.