-
Notifications
You must be signed in to change notification settings - Fork 16.4k
add flexibility for redis service #41811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
reviewed
Sep 27, 2024
romsharon98
reviewed
Sep 27, 2024
Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com>
Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com>
romsharon98
approved these changes
Oct 1, 2024
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* add service type options for redis * additional value * update based on testing * fix syntax * update description * Update chart/templates/redis/redis-service.yaml Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com> * Update chart/templates/redis/redis-service.yaml Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com> --------- Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* add service type options for redis * additional value * update based on testing * fix syntax * update description * Update chart/templates/redis/redis-service.yaml Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com> * Update chart/templates/redis/redis-service.yaml Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com> --------- Co-authored-by: rom sharon <33751805+romsharon98@users.noreply.github.com>
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we are currently experience an issue that requires us to expose redis service through nodeport. update the redis service template so it can accept NodePort as service type
test 1:
default service value
service template rendering to the original one
test 2:
setup clusterIP:
test 3:
setup NodePort
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.