Feature/add pgbouncer and statsd ingress #41759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
nevcohen
reviewed
Aug 26, 2024
nevcohen
reviewed
Aug 26, 2024
romsharon98
commented
Aug 27, 2024
nevcohen
approved these changes
Aug 27, 2024
amoghrajesh
reviewed
Aug 30, 2024
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
@romsharon98 overall the changes look good. Could you add test cases for default values?
Contributor
Author
Most of the default values are set to |
Contributor
On second thought, this is OK. No point of testing empty values |
amoghrajesh
approved these changes
Sep 7, 2024
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
LGTM +1
@jedcunningham WDYT?
eladkal
approved these changes
Sep 15, 2024
eladkal
force-pushed
the
feature/ingress-pgbouncer-statsd
branch
from
a607505 to
466cadd
Compare
gopidesupavan
pushed a commit
to gopidesupavan/airflow
that referenced
this pull request
Sep 17, 2024
* add pgbouncer and statsd ingress * convert pgbouncer to PgBouncer * improve tests, rename flower * change ports * fix tests
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* add pgbouncer and statsd ingress * convert pgbouncer to PgBouncer * improve tests, rename flower * change ports * fix tests
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today pgbouncer and statsd expose /metrics route but we cannot access it outside the cluster.
This PR adds an ingress to pgbouncer and statsd (same as webUI and flower)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.