Make kerberos an optional and devel dependency for impala and fab #41616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
eladkal,
hussein-awala,
pierrejeambrun and
vincbeck
Member
Author
|
Should fix failing compatibility check for Airflow 2.9 (similar case as missing methodtools) |
Member
Author
|
https://github.com/apache/airflow/actions/runs/10472575491/job/29002919190#step:11:4167 is failing compatibility test in main. |
vincbeck
approved these changes
Aug 20, 2024
The improved compatibility tests detected that FAB provider tests have implicit dependency on kerberos - similar as impala. This change make kerberos an optional dependency of FAB as well as it as development dependency for both impala and FAB.
potiuk
force-pushed
the
fix-kerberos-as-devel-dep
branch
from
3835ae8 to
2ee0efe
Compare
hussein-awala
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improved compatibility tests detected that FAB provider tests have implicit dependency on kerberos - similar as impala. This change make kerberos an optional dependency of FAB as well as it as development dependency for both impala and FAB.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.