kubernetes executor cleanup_stuck_queued_tasks optimization #41220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
dirrao
force-pushed
the
k8s_cleanup_stuck_queued_tasks_optimization
branch
from
0a03529 to
bef1e02
Compare
dirrao
force-pushed
the
k8s_cleanup_stuck_queued_tasks_optimization
branch
from
b10bf25 to
4459e0f
Compare
Contributor
Author
|
@jedcunningham / @hussein-awala |
romsharon98
reviewed
Aug 6, 2024
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py
Outdated
Show resolved
Hide resolved
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py
Outdated
Show resolved
Hide resolved
dirrao
force-pushed
the
k8s_cleanup_stuck_queued_tasks_optimization
branch
from
691f142 to
5b8e059
Compare
romsharon98
approved these changes
Aug 8, 2024
Contributor
Author
|
@jedcunningham / @hussein-awala |
Contributor
Author
eladkal
force-pushed
the
k8s_cleanup_stuck_queued_tasks_optimization
branch
from
4538ec4 to
0b1d4a5
Compare
Member
Member
|
@dirrao can you add some details in the description? Just repeating the commit message/title isn't very useful, and having to go grok 100+ lines of change to know what the goal is isn't great for reviewing now nor next year when someone is doing git blame :) e.g. things like what is done now, what you are doing instead, expected impact. |
Contributor
Author
Sorry for not putting the details around the problem. I have updated the details in description of the PR. |
Contributor
|
@dirrao can you rebase and resolve conflicts? |
Contributor
Author
Done. |
potiuk
approved these changes
Oct 7, 2024
96 tasks
kunaljubce
pushed a commit
to kunaljubce/airflow
that referenced
this pull request
Oct 13, 2024
…1220) * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * Updated comment * Provider change log and version updated * Update the worker pod and task comparison from labels to annotations
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
…1220) * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * Updated comment * Provider change log and version updated * Update the worker pod and task comparison from labels to annotations
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
…1220) * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * Updated comment * Provider change log and version updated * Update the worker pod and task comparison from labels to annotations
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…1220) * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * kubernetes executor cleanup_stuck_queued_tasks optimization * Updated comment * Provider change log and version updated * Update the worker pod and task comparison from labels to annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Airflow running the cleanup_stuck_queued_tasks function on a certain frequency. When we run the airflow on a large Kube cluster (pods more than > 5K). Internally the cleanup_stuck_queued_tasks function loops through each queued task (when they breach task queued timeout) and checks the corresponding worker pod existence in the Kube cluster. Right now, this existence check using list pods Kube API. The API is taking more than 1s. if there are 120 queued tasks, then it will take ~ 120 seconds (1s * 120). So, this leads the scheduler to spend most of its time in this function rather than scheduling the tasks. It leads to none of the jobs being scheduled or degraded scheduler performance.
Solution: Use single k8 list pods batch api call to get all the worker pod owned by scheduler. Prepare the set of searchable strings using pod annotations. Use this set data structure and identify whether the task associated pod exists or not. This reduces the number kube api sever calls significantly.
set elements string format:
(dag_id=<dag_id>,task_id=<task_id>,[,map_index=<map_index>],[run_id=<run_id>]
Note: Switch the worker pod and task comparison from labels to annotations to avoid extra processing (make_safe_label_value) and ensure more accurate comparisons, as annotations have no value restrictions.