-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fail the task if the xcom sidecar container does not start for a long time #40909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jhongy1994
wants to merge
2
commits into
apache:main
from
jhongy1994:fix/wait-forever-XCOM_sidecar_container-start
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -721,14 +721,27 @@ def read_pod(self, pod: V1Pod) -> V1Pod: | |
| except HTTPError as e: | ||
| raise AirflowException(f"There was an error reading the kubernetes API: {e}") | ||
|
|
||
| def await_xcom_sidecar_container_start(self, pod: V1Pod) -> None: | ||
| def await_xcom_sidecar_container_start(self, pod: V1Pod, startup_timeout: int = 120) -> None: | ||
| """ | ||
| Await xcom sidecar container to start running. | ||
|
|
||
| :param pod: | ||
| :param startup_timeout: Timeout (in seconds) for startup of the pod | ||
| """ | ||
| self.log.info("Checking if xcom sidecar container is started.") | ||
| start_time = time.time() | ||
| for attempt in itertools.count(): | ||
| if self.container_is_running(pod, PodDefaults.SIDECAR_CONTAINER_NAME): | ||
| self.log.info("The xcom sidecar container is started.") | ||
| break | ||
| if not attempt: | ||
| self.log.warning("The xcom sidecar container is not yet started.") | ||
| if time.time() - start_time >= startup_timeout: | ||
| msg = ( | ||
| f"Xcom sidecar container took longer than {startup_timeout} seconds to start. " | ||
| "Check the container events in kubernetes to determine why." | ||
| ) | ||
|
||
| raise AirflowException(msg) | ||
| time.sleep(1) | ||
|
|
||
| def extract_xcom(self, pod: V1Pod) -> str: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add test cases for this change? Like basically call this, sleep for certain seconds and then check if the exception came up