Skip to content

Conversation

@o-nikolas
Copy link
Contributor

Publicly "release" the hybrid executor feature, including:

  • Documentation
  • Remove feature gating
    • Remove mocks that disabled the feature gate for testing purposes
    • Removed tests for feature gate itself
  • Possibly a changelog/whats new?

A rendered view of the docs can be seen below:

Screenshot 2024-07-10 at 13-34-00 Executor — Airflow Documentation


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Publicly "release" the hybrid executor feature, including:
- Documentation
- Remove feature flag
- What's new/changelog? TODO
@o-nikolas
Copy link
Contributor Author

@eladkal Do I need to write any change log or what's new blurbs for this one? Let me know what you think.

Also maybe a post for https://airflow.apache.org/blog/ (But that would be outside of this PR of course).

@eladkal
Copy link
Contributor

eladkal commented Jul 10, 2024

@eladkal Do I need to write any change log or what's new blurbs for this one? Let me know what you think.

Also maybe a post for https://airflow.apache.org/blog/ (But that would be outside of this PR of course).

I don't think it requires seperated blog entry but that is always welcome if you want to!
I think we do want newsfragment for segnificant feature.

Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The pros and cons are a nice touch, and thanks for including the rendered version of the docs.

@o-nikolas
Copy link
Contributor Author

@eladkal Do I need to write any change log or what's new blurbs for this one? Let me know what you think.
Also maybe a post for https://airflow.apache.org/blog/ (But that would be outside of this PR of course).

I don't think it requires seperated blog entry but that is always welcome if you want to! I think we do want newsfragment for segnificant feature.

Thanks @eladkal! I may write a blog in the coming week, but for now I'll just add a newsfragment to this PR.

@o-nikolas
Copy link
Contributor Author

@eladkal Do I need to write any change log or what's new blurbs for this one? Let me know what you think.
Also maybe a post for https://airflow.apache.org/blog/ (But that would be outside of this PR of course).

I don't think it requires seperated blog entry but that is always welcome if you want to! I think we do want newsfragment for segnificant feature.

Thanks @eladkal! I may write a blog in the coming week, but for now I'll just add a newsfragment to this PR.

I added a fragment @eladkal, let me know what you think

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaxil kaxil added this to the Airflow 2.10.0 milestone Jul 16, 2024
@kaxil
Copy link
Member

kaxil commented Jul 16, 2024

Can this be merged @o-nikolas ?

@o-nikolas
Copy link
Contributor Author

Can this be merged @o-nikolas ?

Hey! I was waiting for @syedahsn's executor metrics PR to be merged first. But he can always circle back and update these docs as part of his PR I suppose.

@o-nikolas o-nikolas merged commit 43e246d into apache:main Jul 17, 2024
@o-nikolas o-nikolas deleted the onikolas/aip-61/docs_and_feature_release branch July 17, 2024 16:10
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 22, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…40701)

Publicly "release" the multiple executor configuration feature (formerly hybrid), including:
- Documentation
- Remove feature flag
- What's new/changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Executors-core LocalExecutor & SequentialExecutor area:hybrid-executors AIP-61 changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants