Skip to content

Use selectinload in trigger #40487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 3 commits into from
Sep 18, 2024
Merged

Use selectinload in trigger #40487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3a6d4d
Use `selectinload` in trigger
Jun 28, 2024
efa2612
Remove unnecessary `joinedload` import
Jun 30, 2024
2787b5b
Update spelling_wordlist.txt with `selectin`
Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airflow/models/trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from typing import TYPE_CHECKING, Any, Iterable

from sqlalchemy import Column, Integer, String, Text, delete, func, or_, select, update
from sqlalchemy.orm import joinedload, relationship
from sqlalchemy.orm import relationship, selectinload
from sqlalchemy.sql.functions import coalesce

from airflow.api_internal.internal_api_call import internal_api_call
Expand Down Expand Up @@ -75,7 +75,7 @@ class Trigger(Base):
uselist=False,
)

task_instance = relationship("TaskInstance", back_populates="trigger", lazy="joined", uselist=False)
task_instance = relationship("TaskInstance", back_populates="trigger", lazy="selectin", uselist=False)

def __init__(
self,
Expand Down Expand Up @@ -152,7 +152,7 @@ def bulk_fetch(cls, ids: Iterable[int], session: Session = NEW_SESSION) -> dict[
select(cls)
.where(cls.id.in_(ids))
.options(
joinedload(cls.task_instance)
selectinload(cls.task_instance)
.joinedload(TaskInstance.trigger)
.joinedload(Trigger.triggerer_job)
)
Expand Down
1 change: 1 addition & 0 deletions docs/spelling_wordlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,6 +1443,7 @@ Seedlist
seedlist
seekable
segmentGranularity
selectin
Sendgrid
sendgrid
sentimentMax
Expand Down