Skip to content

enable AIRFLOW__CELERY__BROKER_URL_CMD when passwordSecretName is true #40270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 6 commits into from
Aug 4, 2024
Merged

enable AIRFLOW__CELERY__BROKER_URL_CMD when passwordSecretName is true #40270

potiuk merged 6 commits into from
Aug 4, 2024

Conversation

@jx2lee
Copy link
Contributor

@jx2lee jx2lee commented Jun 16, 2024 •
edited
Loading

closes #39985

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jun 16, 2024
@jx2lee jx2lee changed the title enable AIRFLOW__CELERY__BROKER_URL_CMD when redis.passwordSecretName true enable AIRFLOW__CELERY__BROKER_URL_CMD when redis.passwordSecretName is only true Jun 16, 2024
@jx2lee jx2lee changed the title enable AIRFLOW__CELERY__BROKER_URL_CMD when redis.passwordSecretName is only true enable AIRFLOW__CELERY__BROKER_URL_CMD when passwordSecretName is true Jun 16, 2024
@jx2lee jx2lee force-pushed the enable-broker-cmd branch 3 times, most recently from db928fd to bde7ec9 Compare July 3, 2024 12:29
@jx2lee jx2lee marked this pull request as ready for review July 3, 2024 13:48
@eladkal eladkal requested a review from romsharon98 July 5, 2024 09:23
romsharon98
romsharon98 reviewed Jul 5, 2024
View reviewed changes
@jx2lee jx2lee force-pushed the enable-broker-cmd branch from 19faa16 to ab04086 Compare July 6, 2024 05:20
@jx2lee jx2lee force-pushed the enable-broker-cmd branch from ab04086 to 3868e04 Compare July 6, 2024 05:21
amoghrajesh
amoghrajesh reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok but can we add a test specific to this change?

@eladkal
Copy link
Contributor

eladkal commented Jul 20, 2024

@jx2lee can you add the unit test?

@jx2lee
Copy link
Contributor Author

jx2lee commented Jul 20, 2024

@amoghrajesh @eladkal
yes, i've written unit test, but having a little problem in code. I'll push soon.

jx2lee
jx2lee commented Jul 20, 2024
View reviewed changes
@jx2lee jx2lee force-pushed the enable-broker-cmd branch from 3b80669 to 934fa5e Compare July 27, 2024 16:55
romsharon98
romsharon98 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@romsharon98 romsharon98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, the tests looks good.

@potiuk potiuk merged commit 0783ded into apache:main Aug 4, 2024
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 6, 2024
@jedcunningham jedcunningham mentioned this pull request Mar 29, 2025
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amoghrajesh amoghrajesh amoghrajesh left review comments

@potiuk potiuk potiuk approved these changes

@romsharon98 romsharon98 romsharon98 approved these changes

@dstandish dstandish Awaiting requested review from dstandish

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

Assignees

No one assigned

Labels

area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't use AIRFLOW__CELERY__BROKER_URL_CMD in the Helm Chart

6 participants

@jx2lee @eladkal @potiuk @romsharon98 @amoghrajesh @utkarsharma2