Skip to content

Conversation

@shahar1
Copy link
Contributor

@shahar1 shahar1 commented May 29, 2024

closes: #38578

This sets the integration env. and adds a basic test to the drill's hook.
We could add more tests later :)

CC: @potiuk, @eladkal


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 marked this pull request as draft May 29, 2024 21:20
@shahar1 shahar1 force-pushed the drill-integration-tests branch 4 times, most recently from b5f0377 to 0829451 Compare May 29, 2024 21:27
@shahar1 shahar1 marked this pull request as ready for review May 29, 2024 21:27
@potiuk
Copy link
Member

potiuk commented May 30, 2024

LGTM - just one, really small, NIT

@shahar1 shahar1 force-pushed the drill-integration-tests branch from 0829451 to 02cfbf9 Compare May 30, 2024 05:11
@shahar1
Copy link
Contributor Author

shahar1 commented May 30, 2024

The currently failed test seems unrelated

@eladkal eladkal merged commit 4127ce4 into apache:main May 30, 2024
@shahar1 shahar1 deleted the drill-integration-tests branch May 30, 2024 16:24
@utkarsharma2 utkarsharma2 added type:misc/internal Changelog: Misc changes that should appear in change log and removed type:misc/internal Changelog: Misc changes that should appear in change log labels Jun 3, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.0 milestone Jun 3, 2024
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jun 3, 2024
fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add drill test integration

4 participants